-
Notifications
You must be signed in to change notification settings - Fork 469
feat(aap): add redirect request support for api10 on urllib #15443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aap): add redirect request support for api10 on urllib #15443
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 257 ± 4 ms. The average import time from base is: 257 ± 3 ms. The import time difference between this PR and base is: 0.2 ± 0.2 ms. The difference is not statistically significant (z = 1.04). Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate christophe-papazian/api10_redirection_urllib (102d805) with baseline main (2590370) 📈 Performance Regressions (2 suites)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.118µs (SLO: <10.000µs 📉 -48.8%) vs baseline: 📈 +23.4% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.2% ✅ ospathbasename_noaspectTime: ✅ 1.082µs (SLO: <10.000µs 📉 -89.2%) vs baseline: -0.4% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.9% ✅ ospathjoin_aspectTime: ✅ 6.127µs (SLO: <10.000µs 📉 -38.7%) vs baseline: -0.4% Memory: ✅ 40.108MB (SLO: <41.000MB -2.2%) vs baseline: +4.4% ✅ ospathjoin_noaspectTime: ✅ 2.295µs (SLO: <10.000µs 📉 -77.1%) vs baseline: +0.2% Memory: ✅ 40.108MB (SLO: <41.000MB -2.2%) vs baseline: +4.2% ✅ ospathnormcase_aspectTime: ✅ 3.417µs (SLO: <10.000µs 📉 -65.8%) vs baseline: -0.4% Memory: ✅ 40.108MB (SLO: <41.000MB -2.2%) vs baseline: +4.4% ✅ ospathnormcase_noaspectTime: ✅ 0.569µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -1.1% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.2% ✅ ospathsplit_aspectTime: ✅ 4.722µs (SLO: <10.000µs 📉 -52.8%) vs baseline: -0.4% Memory: ✅ 40.147MB (SLO: <41.000MB -2.1%) vs baseline: +4.4% ✅ ospathsplit_noaspectTime: ✅ 1.581µs (SLO: <10.000µs 📉 -84.2%) vs baseline: -0.5% Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.1% ✅ ospathsplitdrive_aspectTime: ✅ 3.573µs (SLO: <10.000µs 📉 -64.3%) vs baseline: -2.1% Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.9% ✅ ospathsplitdrive_noaspectTime: ✅ 0.696µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.3% Memory: ✅ 40.049MB (SLO: <41.000MB -2.3%) vs baseline: +4.5% ✅ ospathsplitext_aspectTime: ✅ 4.488µs (SLO: <10.000µs 📉 -55.1%) vs baseline: -0.4% Memory: ✅ 40.147MB (SLO: <41.000MB -2.1%) vs baseline: +4.8% ✅ ospathsplitext_noaspectTime: ✅ 1.371µs (SLO: <10.000µs 📉 -86.3%) vs baseline: -1.3% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.1% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.369µs (SLO: <20.000µs 📉 -83.2%) vs baseline: 📈 +15.5% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.7% ✅ 1-count-metrics-100-timesTime: ✅ 201.714µs (SLO: <220.000µs -8.3%) vs baseline: -0.3% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +5.0% ✅ 1-distribution-metric-1-timesTime: ✅ 3.279µs (SLO: <20.000µs 📉 -83.6%) vs baseline: -0.8% Memory: ✅ 34.741MB (SLO: <35.500MB -2.1%) vs baseline: +4.9% ✅ 1-distribution-metrics-100-timesTime: ✅ 216.279µs (SLO: <230.000µs -6.0%) vs baseline: ~same Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ 1-gauge-metric-1-timesTime: ✅ 2.155µs (SLO: <20.000µs 📉 -89.2%) vs baseline: -0.6% Memory: ✅ 34.721MB (SLO: <35.500MB -2.2%) vs baseline: +4.6% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.276µs (SLO: <150.000µs -9.1%) vs baseline: -0.4% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ 1-rate-metric-1-timesTime: ✅ 3.070µs (SLO: <20.000µs 📉 -84.6%) vs baseline: +0.5% Memory: ✅ 34.682MB (SLO: <35.500MB -2.3%) vs baseline: +4.3% ✅ 1-rate-metrics-100-timesTime: ✅ 215.246µs (SLO: <250.000µs 📉 -13.9%) vs baseline: +0.2% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +5.0% ✅ 100-count-metrics-100-timesTime: ✅ 20.572ms (SLO: <22.000ms -6.5%) vs baseline: +1.7% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.301ms (SLO: <2.300ms ~same) vs baseline: +1.2% Memory: ✅ 35.036MB (SLO: <35.500MB 🟡 -1.3%) vs baseline: +4.4% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.408ms (SLO: <1.550ms -9.2%) vs baseline: +0.6% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.6% ✅ 100-rate-metrics-100-timesTime: ✅ 2.240ms (SLO: <2.550ms 📉 -12.2%) vs baseline: +0.8% Memory: ✅ 34.642MB (SLO: <35.500MB -2.4%) vs baseline: +4.3% ✅ flush-1-metricTime: ✅ 4.591µs (SLO: <20.000µs 📉 -77.0%) vs baseline: +1.0% Memory: ✅ 35.016MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +4.7% ✅ flush-100-metricsTime: ✅ 174.189µs (SLO: <250.000µs 📉 -30.3%) vs baseline: +0.1% Memory: ✅ 35.212MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +5.0% ✅ flush-1000-metricsTime: ✅ 2.196ms (SLO: <2.500ms 📉 -12.2%) vs baseline: ~same Memory: ✅ 35.920MB (SLO: <36.500MB 🟡 -1.6%) vs baseline: +4.9% 🟡 Near SLO Breach (17 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
bc0739b to
a2529a3
Compare
Description
Provides proper support for API10 when inner requests are automatically redirected.
Also:
TODO:
improve iast test suite. It looks like there are leaks between tests that create recursion errors (probably due to redondant patching)
Testing
This was tested on System tests on new system tests for api10 redirect
DataDog/system-tests#5801
APPSEC-60065